[LLVM][lit] add system-cygwin feature #152780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use.
|
@llvm/pr-subscribers-testing-tools Author: None (jeremyd2019) ChangesThere are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. Full diff: https://github.com/llvm/llvm-project/pull/152780.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 649636d4bcf4c..b04fb25f3c030 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -107,6 +107,8 @@ def __init__(self, lit_config, config):
features.add("system-solaris")
elif platform.system() == "OS/390":
features.add("system-zos")
+ elif sys.platform == "cygwin":
+ features.add("system-cygwin")
# Native compilation: host arch == default triple arch
# Both of these values should probably be in every site config (e.g. as
|
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 12, 2025
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use.